Address a bunch of review comments

2018-09-17 17:16:01 +02:00
parent 1de63f9b16
commit b0aed19823
10 changed files with 21 additions and 14 deletions
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@ -82,7 +82,7 @@ u64 RegenerateTelemetryId() {
    return new_telemetry_id;
 }

-bool VerifyLogin(std::string username, std::string token) {
+bool VerifyLogin(const std::string& username, const std::string& token) {
 #ifdef ENABLE_WEB_SERVICE
    return WebService::VerifyLogin(Settings::values.web_api_url, username, token);
 #else